Fix mobile DM recipient routing - #2927
Draft
plantbob0101 wants to merge 1 commit into
Draft
Conversation
Address every DM participant even when the message body has no explicit mention, and cover direct and threaded sends with regression tests. Co-authored-by: plantbob0101 <[email protected]> Signed-off-by: plantbob0101 <[email protected]>
Independent reviewI checked this draft out at
The recipient normalization here is stronger than #2863: it emits canonical lowercase pubkeys, filters empty values, excludes self, and deduplicates recipients with explicit mentions. However, #2863 predates this PR, directly closes #2835, is non-draft, and has broader regression coverage for threaded DM/media tag ordering. Recommendation: move this PR's normalization loop into #2863, keep #2863's tests, and close this as the duplicate rather than merging two overlapping send-path changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ptag on mobile sendsWhy
Mobile DMs without an explicit
@mentionwere emitted with only the channelhtag. Mention-gated agents therefore never received those events, eventhough the messages appeared in the DM history. Desktop already addresses DM
participants automatically.
Validation
just ci